Add pPrintString function#54
Merged
cdepillabout merged 3 commits intocdepillabout:masterfrom Dec 2, 2019
Merged
Conversation
This patch implements pPrintString, pPrintStringOpt and pHPrintStringOpt functions that are similar to their pPrint counterparts except they take the 'show'ed string of the data type.
Owner
|
@sureyeaah Thanks for sending this PR. I took a quick look at it and I think it looks pretty good. It may take me a few days to do a good review and merge it in. Sorry for making you wait. |
Contributor
Author
|
Okay thanks :) |
Contributor
Author
|
Do we need the lightBg and noColor versions too? |
Owner
|
@sureyeaah I had a couple minutes today so I added the extra functions in commit f0a4bcb. Could you review this commit? Once you sign off on it, I will merge it in and release a new version to Hackage. |
Owner
|
@sureyeaah Thanks! Released to Hackage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements pPrintString, pPrintStringOpt and pHPrintStringOpt
functions that are similar to their pPrint counterparts except they take
the 'show'ed string of the data type. Fixes #53