Fix trace functions not pretty-printing as expected#20
Fix trace functions not pretty-printing as expected#20cdepillabout merged 3 commits intocdepillabout:masterfrom
Conversation
|
@yigitozkavci Thanks for working on this.
You should be able to import modules within the doctests. Here's an example doctest showing this: >>> import Data.List (nub)
>>> nub [1,2,3,1,1,1]
>>> [1,2,3]Although, I don't necessarily think it is that important to use |
|
That's perfect, first time using doctest, that's why :) Did the necessary changes 👍 |
|
Okay, thanks. I'll merge this when the tests pass. |
|
Also, I didn't add the |
Fixes #19
Summary
This PR adds
NoColorcounterparts of trace functions, and implement tests on them (because testing colored output is awkward).Notes
@cdepillabout There is a warning introduced with this PR:
Even though I use it for Doctest, I get this warning. I see we didn't use a non-prelude library for our doctests before, but I want to handle a case with
Mapsince @igrep noticed the bug with that data structure.We can overcome this warning with
{-# OPTIONS_GHC -fno-warn-unused-imports #-}pragma on this module. What do you think?