Only build pretty-simple package in cabal CI. Build web with Nix in CI.#117
Only build pretty-simple package in cabal CI. Build web with Nix in CI.#117cdepillabout merged 3 commits intowebfrom
Conversation
| run: | | ||
| stack test | ||
|
|
||
| nix-build-web: |
There was a problem hiding this comment.
We should probably setup some sort of caching for this, but I don't necessarily think that should hold-up this PR from being merged.
There was a problem hiding this comment.
Note that Miso has it's own Cachix cache: https://github.com/dmjio/miso/blob/master/README.md#begin.
|
Awesome, thanks! |
|
CI failure looks related to ghcjs/jsaddle#133. But |
|
@georgefst I came up with a hacky workaround of just removing the This is definitely hacky, but hopefully it works. |
|
@georgefst Looks like the Nix build is now failing: https://github.com/cdepillabout/pretty-simple/actions/runs/3123785920/jobs/5066666069 Maybe just a temporary network problem with GitHub? |
Hopefully. I've kicked it to try again. |
Hmm, it happened again. No idea what that's about. |
|
@georgefst As far as I can tell, this wasn't caused by this PR, so what about just merging in this PR and then trying to figure out a fix in #116? |
|
I think we really need to do something about caching first. It looks to me like CI might have been about to go and build GHCJS. And if we get that from Cachix instead, the current failure (whatever its cause) looks like it might be avoided. |
|
In my opinion, there are really two problems here:
But I don't think either of these should prevent us from at least merging this PR in, since this PR should still be a strict improvement on #116 |
Yes. I mentioned this in #117 (comment). It's the reason I can build this locally.
In principle, I totally agree with you. But the whole GHCJS ecosystem is very fragile (for now, there's exciting progress around it being merged to GHC proper), and I think caches are all-but-necessary. Even though, Nix being what it is, in theory it should be possible to reproduce. |
Ah, that's unfortunate, but makes sense. I added the cache in ceaaa96 so hopefully this should be good to merge, if you're happy with it. The Nix build now only takes a few minutes. |
This PR just modifies CI to only build
webwith Nix, and have the cabal CI jobs only build thepretty-simplepackage, notweb.It also updates the GHC versions used in CI.
This PR should hopefull be able to be directly merged into #116.