Skip to content

Make use of unsafe yaml forward compatible#267

Merged
cdent merged 1 commit intomasterfrom
bug/266
Mar 5, 2019
Merged

Make use of unsafe yaml forward compatible#267
cdent merged 1 commit intomasterfrom
bug/266

Conversation

@cdent
Copy link
Copy Markdown
Owner

@cdent cdent commented Mar 5, 2019

The forthcoming 5.x release of PyYMAL changes how unsafe
yaml is managed [1]. The default for gabbi is to safe
load but the option has been present to unsafe load if
code-executing functionality was desired. The way to
achieve that in 5.x and beyond is more explicit than
prior versions.

In this change we adjust the unsafe loading to work with
both 3.x and the as yet unreleased 5.x.

Fixes #266

[1] https://msg.pyyaml.org/load

The forthcoming 5.x release of PyYMAL changes how unsafe
yaml is managed [1]. The default for gabbi is to safe
load but the option has been present to unsafe load if
code-executing functionality was desired. The way to
achieve that in 5.x and beyond is more explicit than
prior versions.

In this change we adjust the unsafe loading to work with
both 3.x and the as yet unreleased 5.x.

Fixes #266

[1] https://msg.pyyaml.org/load
Copy link
Copy Markdown

@amoralej amoralej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdent cdent merged commit 0e6b5a3 into master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants