Gaussian Process Batch MSE. Fixes #7329 and #6483#1
Open
ccphillippi wants to merge 1 commit intomasterfrom
Open
Gaussian Process Batch MSE. Fixes #7329 and #6483#1ccphillippi wants to merge 1 commit intomasterfrom
ccphillippi wants to merge 1 commit intomasterfrom
Conversation
62a675a to
369dfa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scikit-learn#7329 and scikit-learn#6483. (Related to Python 3)
I realize this is deprecated, but in case you're still interested in a quick bugfix, my understanding is that this was previously a silent bug even in Python 2.7. In Python 3, this is an error when
n_eval / batch_sizeis not an int.To demonstrate:
Python 2.7 output:
Note 8 corresponds to the sample size so the current version (if converted to an int) would miss the last few samples.