Support more files, and arrays in theme#43
Merged
cchaos merged 4 commits intocchaos:feature/css-in-js_themesfrom Mar 16, 2021
Merged
Support more files, and arrays in theme#43cchaos merged 4 commits intocchaos:feature/css-in-js_themesfrom
cchaos merged 4 commits intocchaos:feature/css-in-js_themesfrom
Conversation
cchaos
reviewed
Mar 16, 2021
| // TODO: All theme files need to be imported here or else they error out. | ||
| // Creation of the themes shouldn't be restricted to a particular file | ||
|
|
||
| export const light = { |
Owner
There was a problem hiding this comment.
Have you tried moving this actual object creation to a separate file?
Basically what I was trying to accomplish was to have a theme file for the default theme and one for the Amsterdam theme in their respective theme folders, similar to like the manifest SASS index.scss files.
Author
There was a problem hiding this comment.
Should be no problem. Just moved all of Amsterdam in b2cd915
I'm guessing any problems you saw previously were due to that comment bug, which is now fixed.
cchaos
reviewed
Mar 16, 2021
Comment on lines
+79
to
+84
| type EuiFontSize = { | ||
| [mapType in EuiFontScale]: { | ||
| fontSize: string; | ||
| lineHeight: string; | ||
| }; | ||
| }; |
cchaos
approved these changes
Mar 16, 2021
Owner
cchaos
left a comment
There was a problem hiding this comment.
👍 Sweet. I'll go ahead and merge and continue to clean up. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you want to actually merge this or just use it as a reference, but this helps with:
getOwnPropertyDescriptor)reduce