Merged
Conversation
9 tasks
cchaos
reviewed
Feb 4, 2021
Owner
cchaos
left a comment
There was a problem hiding this comment.
Yeah I was going to progress upward through the page components updating the docs as I go which is why I intentionally didn't touch the other examples for now. But we can add now and continue to update too.
I've made review comments, but I'll apply them all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some docs stuff. Mostly making the top example more clear and better defining the titles so they better describe when they show components vs. full layouts.