Skip to content

use callback instead of resizeObserver#27

Merged
cchaos merged 3 commits intocchaos:into-feature/range-dropdownsfrom
thompsongl:into-feature/range-dropdowns
Sep 9, 2019
Merged

use callback instead of resizeObserver#27
cchaos merged 3 commits intocchaos:into-feature/range-dropdownsfrom
thompsongl:into-feature/range-dropdowns

Conversation

@thompsongl
Copy link
Copy Markdown

Plug into the underlying change event instead of relying on event-driven DOM APIs

@cchaos
Copy link
Copy Markdown
Owner

cchaos commented Sep 5, 2019

Works great in Firefox and Chrome, IE has a little animation for the single slider but I'm ok with that. The only problem I'm finding is that as soon as I click on the slider in IE, the dropdown disappears.

@thompsongl thompsongl force-pushed the into-feature/range-dropdowns branch from d707380 to 657e3d8 Compare September 9, 2019 17:30
@thompsongl
Copy link
Copy Markdown
Author

@cchaos IE11 should be passable now

@cchaos
Copy link
Copy Markdown
Owner

cchaos commented Sep 9, 2019

Unfortunately this issue is also and still happening in Safari

@cchaos
Copy link
Copy Markdown
Owner

cchaos commented Sep 9, 2019

Awesome! All the browsers are working now, thank you!

@cchaos cchaos merged commit 5d169d0 into cchaos:into-feature/range-dropdowns Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants