Handle calling convention differences#11
Merged
cbezault merged 2 commits intocbezault:kernelfrom Dec 21, 2020
Merged
Conversation
Owner
|
We also have no plans to ever run an x86 kernel in the CI system so we won't be able to support these tests in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"ninja" was successful on all four platforms (amd64, x86, arm, arm64).
Running
python tests\utils\stl-lit\stl-lit.py ..\..\..\tests\std\tests\Dev11_0863628_atomic_compare_exchangesucceeded on x64 (because I'm testing on an x64 system). On x86, the compile and link portions worked, but running failed (as expected) because I'm not running an x86 kernel. On arm and arm64, running the kernel loader failed, as expected, because it's an arm executable, not an x86 executable.