Add contains check for canvas when removing#229
Merged
catdad merged 2 commits intocatdad:masterfrom Apr 30, 2024
Merged
Conversation
2 tasks
Owner
|
Makes sense, thanks for contributing! |
Owner
|
It's worth mentioning though, |
Owner
|
This was released in 1.9.3 |
Contributor
Author
Ah gotcha, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're running in a context where the current document.body has been switched,
donewill still try to remove the canvas from the new document.body, which will never work. This PR adds a check to ensure the canvas is contained within the body before removing it.