Fix counting of UTF-8 codepoints in TextFlow#3086
Merged
horenmar merged 1 commit intocatchorg:develfrom Apr 1, 2026
Merged
Conversation
For line-wrapping bytes were counted instead of codepoints. This resulted in line-breaks being inserted at the wrong position and also breaking UTF-8 characters. Fixes catchorg#1022.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3086 +/- ##
==========================================
+ Coverage 91.34% 91.35% +0.01%
==========================================
Files 204 204
Lines 8899 8912 +13
==========================================
+ Hits 8128 8141 +13
Misses 771 771 🚀 New features to boost your workflow:
|
Member
Dumb jokes aside, historically Catch2 did not try to handle non-ascii text (with minor concessions here and there), because of the sad state of C++ support for doing so. I think this is unobtrusive-enough to be worth it though. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For line-wrapping bytes were counted instead of codepoints. This resulted in line-breaks being inserted at the wrong position and also breaking UTF-8 characters.
Maybe AnsiSkippingString should be renamed to Utf8SkippingString now?
GitHub Issues
Fixes #1022.