Apply PR #2297 to devel branch#2300
Merged
horenmar merged 3 commits intocatchorg:develfrom Oct 21, 2021
Merged
Conversation
It turns out that Issue catchorg#2272 partially affected the devel branch. When building tests with C++20, the compiler emits a warning that top-level comma expressions in array subscripts are depricated. Warnings are treated as errors, so this caused the build to fail. This commit adds localized warning suppression in accordance with this recommendation here: catchorg#2297 (comment) Signed-off-by: Alecto Irene Perez <perez.cs@pm.me>
Contributor
Author
|
It's important to note that part of the fix applied in #2297 (removing using declarations for deleted functions inside the custom allocator class) wasn't necessary for the devel branch. |
This commit fixes an unkwown pragma warning on older versions of GCC and Clang. These older versions don't have a warning for depricated use of the comma subscript. Because warning suppression is localized, and only refers to the comma subscript warning, it doesn't affect compiler warnings in other parts of the code. Signed-off-by: Alecto Irene Perez <perez.cs@pm.me>
Signed-off-by: Alecto Irene Perez <perez.cs@pm.me>
Codecov Report
@@ Coverage Diff @@
## devel #2300 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 150 150
Lines 7139 7139
=======================================
Hits 6501 6501
Misses 638 638 |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It turns out that Issue #2272 partially affected the devel branch. When building tests with C++20, the compiler emits a warning that top-level comma expressions in array subscripts are depricated. Warnings are treated as errors, so this caused the build to fail.
This commit adds localized warning suppression in accordance with this recommendation here.
GitHub Issues
It turns out that Issue #2272 also partially applied to the devel branch. This issue was marked as closed, but the fix was only ever applied to the 2.x release branch, and still exists on the devel branch.