Passthrough stdout/err in multireporter's partial test end

horenmar · horenmar · commit b5547f2ef6be · 2022-01-01T14:20:23.000+01:00
This should provide the same overall stdout/err, but the new
output should feel "faster" for test cases that are entered
and exited multiple times (e.g. due to generators).
diff --git a/src/catch2/reporters/catch_reporter_listening.cpp b/src/catch2/reporters/catch_reporter_listening.cpp
@@ -136,21 +136,22 @@ namespace Catch {
 
     void ListeningReporter::testCasePartialEnded( TestCaseStats const& testStats,
                                                   uint64_t partNumber ) {
-        // TODO: Fix handling of stderr/stdout?
+        if ( m_preferences.shouldRedirectStdOut &&
+             m_haveNoncapturingReporters ) {
+            if ( !testStats.stdOut.empty() ) {
+                Catch::cout() << testStats.stdOut << std::flush;
+            }
+            if ( !testStats.stdErr.empty() ) {
+                Catch::cerr() << testStats.stdErr << std::flush;
+            }
+        }
+
         for ( auto& reporterish : m_reporterLikes ) {
             reporterish->testCasePartialEnded( testStats, partNumber );
         }
     }
 
     void ListeningReporter::testCaseEnded( TestCaseStats const& testCaseStats ) {
-        if ( m_preferences.shouldRedirectStdOut && m_haveNoncapturingReporters ) {
-            if ( !testCaseStats.stdOut.empty() ) {
-                Catch::cout() << testCaseStats.stdOut << std::flush;
-            }
-            if ( !testCaseStats.stdErr.empty() ) {
-                Catch::cerr() << testCaseStats.stdErr << std::flush;
-            }
-        }
         for ( auto& reporterish : m_reporterLikes ) {
             reporterish->testCaseEnded( testCaseStats );
         }
