Fix ArgumentException: "Could not find method overriding method" with overridden class method having generic by-ref parameter#657
Merged
stakx merged 3 commits intocastleproject:masterfrom Aug 28, 2023
Conversation
Member
Author
|
@castleproject/committers, I'll leave this open for review for a week or two, but since it seems like a pretty straightforward bug fix, I'll merge it after that. |
jonorossi
approved these changes
Aug 24, 2023
Member
jonorossi
left a comment
There was a problem hiding this comment.
Makes sense.
I think the changelog should acknowledge yourself as the fixer rather than the bug reporter, or both since they provided some test code.
This triggers a `ArgumentException`: "Could not find method overriding [...]. This is most likely a bug. Please report it."
c6c222c to
46fbe94
Compare
46fbe94 to
d7d8f6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #655.