Merged
Conversation
stakx
commented
Jun 8, 2020
jonorossi
approved these changes
Jun 9, 2020
* Types in this library that used to subclass `MarshalByRefObject` no longer do so. * `ProxyUtil.IsProxy` no longer tests for transparent proxies (i.e. remoting proxies created by the runtime); that method now tests ex- clusively for proxies created by DynamicProxy. * DynamicProxy will still recognize `MarshalByRefObject` and exclude that type's methods when creating a proxy type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #501 (comment), where it was mentioned that there's no future for .NET remoting.
We can keep some minimal support for .NET remoting where it doesn't cost us anything (excluding
MarshalByRefObjectmethods during proxy type creation), but there will be functional changes with ournet45target. See the commit message for details.@jonorossi, I've never worked much with app domains and remoting, so I figured we might just gear v5's feature set towards "modern" .NET; regarding backwards compatibility (i.e.
net45), I'll defer to your judgement whether these changes are acceptable.