Example: Added tests to show a race condition when intercepting an async method#337
Closed
JSkimming wants to merge 1 commit intocastleproject:masterfrom
Closed
Example: Added tests to show a race condition when intercepting an async method#337JSkimming wants to merge 1 commit intocastleproject:masterfrom
JSkimming wants to merge 1 commit intocastleproject:masterfrom
Conversation
Member
|
@JSkimming thanks again for the unit tests. I'm going to close this pull request to hide it from the list, it is linked to from #145 so won't get lost. We haven't forgotten about it, however as you already know it isn't a quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a functional PR, just an attempt to demonstrate a race condition in AbstractInvocation.
This demonstrates the issue I outlined in #145, specifically this comment.