Skip to content

Add change validation for maximum field constraints to CRD Upgrade safety preflight check #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
praveenrewar merged 1 commit into from
May 8, 2024
Merged

Add change validation for maximum field constraints to CRD Upgrade safety preflight check #951

praveenrewar merged 1 commit into from
May 8, 2024

Conversation

@rashmigottipati
Copy link
Contributor

@rashmigottipati rashmigottipati commented May 3, 2024

What this PR does / why we need it:

This PR adds change validation to the CRD Upgrade Safety preflight check to prevent changes to the following field constraints during a CRD upgrade operation:

  • maximum
  • maxLength
  • maxItems
  • maxProperties

Which issue(s) this PR fixes:

#914

Does this PR introduce a user-facing change?

Add change validation to the CRDUpgradeSafety pre-flight check that field constraints such as maximum, maxLength, maxItems and maxProperties are not added or decreased during a CRD upgrade

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@rashmigottipati
Copy link
Contributor Author

rashmigottipati commented May 3, 2024

cc @everettraven

@rashmigottipati rashmigottipati mentioned this pull request May 3, 2024
Closed
everettraven
everettraven reviewed May 3, 2024
View reviewed changes
@rashmigottipati
Add change validation for maximum constraints to CRD Upgrade safety p…
14379d8 
…reflight check

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati rashmigottipati force-pushed the feature/add-maximums-validation-check branch from 0acdf73 to 14379d8 Compare May 7, 2024 14:14
@rashmigottipati
Copy link
Contributor Author

rashmigottipati commented May 7, 2024

Rebased and squashed commits.

praveenrewar
praveenrewar approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar merged commit 8e9fbd2 into carvel-dev:develop May 8, 2024
This was referenced May 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

+1 more reviewer

@everettraven everettraven everettraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Carvel
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rashmigottipati @praveenrewar @everettraven