feat: add layer and image size information to describe command #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f38b52f to
b33d616
Compare
- Add Size field to Layers struct to track individual layer sizes - Add Size field to ImageInfo struct to track total image size - Modify getImageLayersInfo function to calculate and return both layer sizes and total image size - Update text output format to display image size information - Maintain backward compatibility with existing functionality This enhancement provides users with detailed size information for both individual layers and total image sizes when using the describe command with the --layers flag. Signed-off-by: Marin Dzhigarov <m.dzhigarov@gmail.com>
b33d616 to
f57b20f
Compare
Signed-off-by: Marin Dzhigarov <m.dzhigarov@gmail.com>
cf189df to
e92ceda
Compare
Signed-off-by: Marin Dzhigarov <m.dzhigarov@gmail.com>
Member
|
Can you please revise develop? |
Contributor
Author
Done |
Contributor
|
@mdzhigarov @joaopapereira created a PR #761 to run ghcr external tests based on PAT user configured to access ghcr registry packages and workflows |
Contributor
|
merging the PR as env secrets are not accessible to fork users. The test has succeeded earlier using workflow_dispatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
imgpkg describecommand to include size information for both individual layers and total image sizes when using the--layersflag.Changes
Sizefield toLayersstruct to track individual layer sizesSizefield toImageInfostruct to track total image sizegetImageLayersInfofunction to calculate and return both layer sizes and total image sizeTesting
Example Output
When using
imgpkg describe -b <bundle> --layers, users will now see: