Copy api #668
Merged
Copy api #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenrewar
reviewed
Jun 3, 2024
Member
praveenrewar
left a comment
There was a problem hiding this comment.
(Still going through but mostly looks pretty good)
| name: basic | ||
| authors: | ||
| - name: Carvel Team | ||
| email: carvel@vmware.com |
praveenrewar
approved these changes
Jun 10, 2024
Member
|
@joaopapereira I think a rebase will be required to trigger the tests again (without the harbor test). |
Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change on the
v1.SignatureFetcherI decided to do this so that we do not have another interface to do the same thing. Nevertheless we can create a new Interface and eventually deprecate this one.