Limit session IDs to a non-negative, pseudo-random int32 #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, this reduces the set from which session IDs are drawn by (9.999.999.999 - 2.147.483.647) = 7.852.516.352, say 75%. Practically, ~2e10 possible session IDs should be large enough to avoid collisions in the real-world. This fixes an int overflow for 386 architectures. Fixes carvel-dev#663 Signed-off-by: Max Brauer <mbrauer@vmware.com>
joaopapereira
approved these changes
May 14, 2024
Member
joaopapereira
left a comment
There was a problem hiding this comment.
I am ok with the change. If we see any issue with this session ID in the future, we can always go for an Alphanumerical session ID, which will increase the number of possibilities again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, this reduces the set from which session IDs are drawn by (9.999.999.999 - 2.147.483.647) = 7.852.516.352, say 75%.
Practically, ~2e10 possible session IDs should be large enough to avoid collisions in the real-world.
This fixes an int overflow for 386 architectures.
Fixes #663