Skip to content

Plivo Support#143

Merged
caronc merged 7 commits intomasterfrom
plivo-support
Sep 15, 2024
Merged

Plivo Support#143
caronc merged 7 commits intomasterfrom
plivo-support

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Aug 23, 2019 •
edited
Loading

New Service Completion Status

  • apprise/plugins/NotifyPlivo.py
  • setup.py
    • add new service into the keywords section of the setup() declaration
  • README.md
    • add entry for new service to table (as a quick reference)
  • packaging/redhat/python-apprise.spec
    • add new service into the %global common_description

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Syntax

  • plivo://{auth_id}@{token}/{from_phoneno}
  • plivo://{auth_id}@{token}/{from_phoneno}/{to_phoneno}
  • plivo://{auth_id}@{token}/{from_phoneno}/{to_phone_no}/{to_phone_no2}/{to_phone_noN}/

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@plivo-support

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "plivo://auth@token/555-555-5555"

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #143    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          57     58     +1     
  Lines        6653   6760   +107     
  Branches     1052   1065    +13     
======================================
+ Hits         6653   6760   +107
Impacted Files Coverage Δ
apprise/plugins/NotifyPlivo.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff48cb...dd097b6. Read the comment docs.

Repository owner deleted a comment from codecov-io Aug 23, 2019
@caronc
Copy link
Owner Author

caronc commented Aug 27, 2019 •
edited
Loading

Plivo support placed on hold due to upstream restrictions.

I'm specifically looking for details on the {auth_id} and {auth_token}; information such as knowing if it's alpha/numeric characters that accepts dashes, how many characters are expected, etc. Usually I'd have just make an account and figure this out for myself (since this info is passed right to me). An account would allow me to even test everything, but unfortunately i can't...

Plivo does not allow you to sign up with their service using a @gmail.com email account. I reached out to support asking for permission and explaining how I'd like to add them to this tool.... Here is their response:
06-Plivo

If anyone has an account and is willing to just share me the {auth_id} and {auth_token} structure (not your account personal details) allowing me to complete this pull request, that would be awesome! 🙂

The PR is pretty much completed already and would require very subtle changes to get going once the missing details are known.

@caronc caronc added the blocked Blocked due to missing information and/or an issue outside of this project. label Aug 27, 2019
@codecov-io
Copy link

codecov-io commented Sep 6, 2019 •
edited
Loading

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #143   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          71     72    +1     
  Lines        8323   8419   +96     
  Branches     1333   1346   +13     
=====================================
+ Hits         8323   8419   +96
Impacted Files Coverage Δ
apprise/plugins/NotifyPlivo.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408810d...bbd60ee. Read the comment docs.

@caronc caronc force-pushed the master branch 3 times, most recently from 4926a03 to 93efa2d Compare August 31, 2020 17:31
@dgtlmoon
Copy link
Contributor

dgtlmoon commented Jan 19, 2022

Maybe if Plivo support was easier to implement, they'de get more customers 👯 :)

@caronc caronc added awaiting public confirmation it works and removed blocked Blocked due to missing information and/or an issue outside of this project. labels Jul 13, 2022
@amotl
Copy link
Collaborator

amotl commented Nov 7, 2022

Maybe this issue can be revisited? Ideally, we may find someone from @plivo who likes Apprise to gain corresponding support and who would endorse this in a positive way. It would be so sweet.

/cc @narayana-plivo, @kalyan-plivo

@narayana-plivo
Copy link

narayana-plivo commented Nov 7, 2022

@amotl sure we will check and get back to you soon.

@caronc caronc mentioned this pull request Dec 18, 2022
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.35%. Comparing base (09cd2b6) to head (ff3b57f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master     #143    +/-   ##
========================================
  Coverage   99.35%   99.35%            
========================================
  Files         147      148     +1     
  Lines       20326    20438   +112     
  Branches     3979     3997    +18     
========================================
+ Hits        20195    20307   +112     
  Misses        121      121            
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc
Copy link
Owner Author

caronc commented Dec 18, 2022

Rebased code with master since this branch was really outdated (and with merge conflicts).

@tombii
Copy link

tombii commented Apr 18, 2023

From my account, so one data point:
{auth_id} is 20 characters
{auth_token} is 40 characters
Both alphanumeric, no dashes or other special characters.

@caronc
Copy link
Owner Author

caronc commented May 13, 2023

@tombii would love it if you could give it another shot! 🙂

@caronc caronc merged commit 56bcbf5 into master Sep 15, 2024
@caronc caronc deleted the plivo-support branch March 16, 2025 20:27
@yashuatla yashuatla mentioned this pull request Jun 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@caronc @codecov-io @dgtlmoon @amotl @narayana-plivo @codecov-commenter @tombii