Dbus/Glib Python binding update + test refactoring#1377
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 170 171 +1
Lines 21993 22104 +111
Branches 3470 3480 +10
========================================
+ Hits 21917 22028 +111
Misses 68 68
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6351956 to
2ef4e36
Compare
2ef4e36 to
0921517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #984
This is based on the PR #992 and the amazing work started by @qarkai way back in 2023 👀
I have finally had time to go through the changes and still remain backwards compatible with what was there. More importantly the test coverage has been sigifigantly refactored. The idea was to support a path people can leverage that does not require the legacy and unsupported dbus-python references (yet still offer them) while moving towards the more ideal approach.
How it works:
glib://andgio://leverage the new waydbus://,qt://andkde://still remain working using the old functionalityChecklist
tox -e lint)tox -e minimal)Testing
Anyone can help test this source code as follows: