Skip to content

Dbus/Glib Python binding update + test refactoring#1377

Merged
caronc merged 4 commits intomasterfrom
984-dbus-python-refactoring
Jul 31, 2025
Merged

Dbus/Glib Python binding update + test refactoring#1377
caronc merged 4 commits intomasterfrom
984-dbus-python-refactoring

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Jul 30, 2025

Description:

Related issue (if applicable): #984

This is based on the PR #992 and the amazing work started by @qarkai way back in 2023 👀

I have finally had time to go through the changes and still remain backwards compatible with what was there. More importantly the test coverage has been sigifigantly refactored. The idea was to support a path people can leverage that does not require the legacy and unsupported dbus-python references (yet still offer them) while moving towards the more ideal approach.

How it works:

  • glib:// and gio:// leverage the new way
  • For backwards compatibility, dbus://, qt:// and kde:// still remain working using the old functionality

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use tox -e lint)
  • 100% test coverage (use tox -e minimal)

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@984-dbus-python-refactoring

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  glib://

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.65%. Comparing base (8e1dad9) to head (e4def6d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1377    +/-   ##
========================================
  Coverage   99.65%   99.65%            
========================================
  Files         170      171     +1     
  Lines       21993    22104   +111     
  Branches     3470     3480    +10     
========================================
+ Hits        21917    22028   +111     
  Misses         68       68            
  Partials        8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caronc caronc force-pushed the 984-dbus-python-refactoring branch 2 times, most recently from 6351956 to 2ef4e36 Compare July 30, 2025 11:14
@caronc caronc force-pushed the 984-dbus-python-refactoring branch from 2ef4e36 to 0921517 Compare July 30, 2025 14:48
@caronc caronc merged commit b0fff4b into master Jul 31, 2025
17 checks passed
@caronc caronc mentioned this pull request Jul 31, 2025
4 tasks
@caronc caronc deleted the 984-dbus-python-refactoring branch August 1, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant