Fix matrix v3 attachments#1373
Fix matrix v3 attachments#1373caronc merged 6 commits intocaronc:masterfrom privacyfr3ak:fix_matrix_v3_attachments
Conversation
|
This is amazing; thank you so much; I just did a very, very, very large merge request. Hopefully your efforts aren't mucked up too much, but would you mind just rebasing (i see there are 2 conflicts). New updates allow you to do a lot more work with I properly integrated I'm sorry for the inconvienince; I do apprecate your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1373 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 170 170
Lines 21981 21989 +8
Branches 3467 3469 +2
=======================================
+ Hits 21905 21913 +8
Misses 68 68
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I merged your last commit and managed the conflict. I did the formating and rerun the unit tests and local tests. Everything seems fine. |
|
I'm not familiar with how the workflows works but it seems to fail because ${{ secrets.CR_PAT }} is equal to ''. I would suspect this variable is not available in the current context. |
|
Merged! Thank you! 🚀 |
Sorry @privacyfr3ak ; i didn't see your reply. I did fix this. It was exactly what you're eluding to... i'm good with code, but still learning workflows 🙂 . I didn't realize the key would only work for my commits and not others. I learned i could make the repo being referenced public (as there was nothing to hide anyway - didn't realize it was private) and drop the credentials entirely. Seems to be fine (for next time anyway we're good). Thanks again for PR! |
|
It has been a pleasure to contribute to this great project. |

Description:
Related issue (if applicable): #
I noticed attachment was disabled and ignored on matrix v3 since it was broken in the upgrade to v3. I used the code commented with # FUTURE as a reference and tried to debug that. I noticed that the sending of mxc url was not upgraded to use PUT instead of POST. I also added the increment of the transaction ID after that part. Otherwise the rest of the message is ignored. I think I fixed the unit tests properly. I also did some local test with my tuwunel instance to send image and zip file without any problem with v3 enabled.
New Service Completion Status
%global common_descriptionChecklist
flake8)Testing
Anyone can help test this source code as follows: