Fix test case to compare url ids#1371
Fix test case to compare url ids#1371caronc merged 1 commit intocaronc:masterfrom emmanuel-ferdman:master
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1371 +/- ##
=========================================
Coverage ? 99.64%
=========================================
Files ? 173
Lines ? 22479
Branches ? 3561
=========================================
Hits ? 22399
Misses ? 72
Partials ? 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I wish i saw this PR a while ago... README.md has been updated, but likely still suffers from what you found. Could you just do a quick rebase and see if your changes are still applicable? |
1 similar comment
|
I wish i saw this PR a while ago... README.md has been updated, but likely still suffers from what you found. Could you just do a quick rebase and see if your changes are still applicable? |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
|
@caronc I converted this PR to another fix. Hope this one is fine. thanks for the review 😄 |
|
Great catch! |
PR Summary
This small PR fixes the test case to compare different url ids.