Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.38%. Comparing base (70cb7d8) to head (b35586e).
Report is 1 commits behind head on master.

@@           Coverage Diff           @@
##           master    #1347   +/-   ##
=======================================
  Coverage   99.37%   99.38%           
=======================================
  Files         161      162    +1     
  Lines       21069    21159   +90     
  Branches     3791     3804   +13     
=======================================
+ Hits        20938    21028   +90     
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is really great; i made some subtle changes to help assist you to get this merged.

1. added full test coverage (you had a good start)
2. filled in some missing functions you didn't have (__len__() and url_identifier())
3. fixed url() to properly generate a valid re-usable Apprise URL

I also updated your URL suport a bit. It appears the from= is not mandatory? So the URLs changed to:

• clickatell://apikey/targets
• clickatell://from_phone@apikey/targets

this makes it a bit easier to parse the URL. Please do a git pull in your own branch to sync up with my changes and verify everything still works for you. If it does, I can go ahead and merge.

Great work! 🚀

Thanks for your help! I'd say the changes work, but I've found out a problem which I probably overlooked in the first place. Introducing several targets does not work because Clickatell only supports one target per call. It does not expect a list of to. I'll try to find a workaround for that (maybe the best solution is simply disable the multiple targets option in apprise service). What do you think?

Not an issue at all, this is solved all throughout Apprise. You just need to update the send() to run through a while loop instead. See the ntfy example.

Lots of other examples too. You're very close at this point to being able to support multiple targets

Some subtle additional change made:

• use params= instead of building URL yourself on the fly.
• if a target can't be notified, move on to the next (don't fail early)
• Initializing title_maxlen = 0 in your class object looks after taking a title (if one was provided) and concatinating the body after it for you. No need to do this yourself. This is used by all SMS messages
• Rest of changes look fine... let me know if this still works for you and we can do the merge!

Edit: Above changes were pushed, so you just need to sync up git pull

Just tested. It works perfectly fine. Thank you very much!

Merged! 🚀

Hi, and no rush! Just wondering about releasing phase... When should I expect a new release? How often are releases done? Thanks!

I apologize, I'm very slow releasing these days as I like to wait until I have accumulated enough new changes to warrant one. I travel a lot for my work, so this also compounds on the slow release cycles... The code base doesn't build in size as fast as it would in the past.

Let's let the code base sit for at least one more month. I'd like to get a few more lingering PRs merged. I'm hopeful that the ones I've actioned for others can be tested like you did for yours.