Skip to content

apprise.urls() bulletproofing/bugfix#1302

Merged
caronc merged 1 commit intomasterfrom
1297-config-url-bugfix
Mar 10, 2025
Merged

apprise.urls() bulletproofing/bugfix#1302
caronc merged 1 commit intomasterfrom
1297-config-url-bugfix

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Mar 10, 2025 •
edited
Loading

Description:

Related issue (if applicable): #1297

Bugfix to prevent apprise.urls() from working when a AppriseConfig() has been defined within it.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1297-config-url-bugfix

@codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (bd270ef) to head (d0a1678).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1302   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         160      160           
  Lines       20915    20921    +6     
  Branches     3759     3761    +2     
=======================================
+ Hits        20784    20790    +6     
  Misses        121      121           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caronc caronc merged commit 3cc9866 into master Mar 10, 2025
13 checks passed
@caronc caronc deleted the 1297-config-url-bugfix branch March 16, 2025 20:26
@yashuatla yashuatla mentioned this pull request Jun 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@caronc