Skip to content

mmost:// supports legacy url webhooks (http://)#1258

Merged
caronc merged 1 commit intomasterfrom
1245-mattermost-native-url-support
Dec 15, 2024
Merged

mmost:// supports legacy url webhooks (http://)#1258
caronc merged 1 commit intomasterfrom
1245-mattermost-native-url-support

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Dec 15, 2024

Description:

Related issue (if applicable): #1245

Mattermost supports parsing Native (http:// and https://) URLs as long as they conform to the following:

  • https://mattermost.HOSTNAME/hooks/TOKEN
  • http://mattermost.HOSTNAME/hooks/TOKEN

Rules for this to trigger:

  • Must be part of mattermost subdomain

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1245-mattermost-native-url-support

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "https://mattermost.example.com/hooks/token-identifier-here"

@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (12f8da9) to head (957b592).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         159      159           
  Lines       20707    20713    +6     
  Branches     3723     3723           
=======================================
+ Hits        20576    20582    +6     
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant