Skip to content

Refactored the way Notifiarr Discord users are mentioned#1153

Merged
caronc merged 1 commit intomasterfrom
notifiarr-discord-mentions-refactor
Jul 10, 2024
Merged

Refactored the way Notifiarr Discord users are mentioned#1153
caronc merged 1 commit intomasterfrom
notifiarr-discord-mentions-refactor

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Jul 2, 2024 •
edited
Loading

Description:

Related issue (if applicable): n/a

The concern came from the Notifiarr Discord chat where one would invoke discord mentions from Apprise.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@notifiarr-discord-mentions-refactor

# Test out the changes with the following command:
apprise -t "Test Title" -b "Hi <@123>!" \
  notifiarr://webhook/discord_channel_no/

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (6733953) to head (f28615d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   99.28%   99.26%   -0.03%     
==========================================
  Files         142      142              
  Lines       18440    18428      -12     
  Branches     3763     3761       -2     
==========================================
- Hits        18309    18292      -17     
- Misses        121      124       +3     
- Partials       10       12       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 631ce10 into master Jul 10, 2024
@caronc caronc deleted the notifiarr-discord-mentions-refactor branch July 26, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caronc @codecov-commenter