Skip to content

Slack supports <@userid> in message body#1134

Merged
caronc merged 1 commit intomasterfrom
849-slack-userid-in-body
May 28, 2024
Merged

Slack supports <@userid> in message body#1134
caronc merged 1 commit intomasterfrom
849-slack-userid-in-body

Conversation

@caronc
Copy link
Owner

@caronc caronc commented May 28, 2024 •
edited
Loading

Description:

Related issue (if applicable): #849

Added support for <@userid> and <@userid|desc> to slack payload

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@849-slack-userid-in-body

# Test out the changes with the following command:
apprise -t "Test Title" -b "Hi <@U1ZQL9N3Y>!" \
  "slack://credentials/"

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (da14b3a) to head (1ef401c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1134   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         140      140           
  Lines       18229    18234    +5     
  Branches     3728     3729    +1     
=======================================
+ Hits        18098    18103    +5     
  Misses        121      121           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit e289279 into master May 28, 2024
@caronc caronc deleted the 849-slack-userid-in-body branch May 28, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caronc @codecov-commenter