Skip to content

Slack files upload deprecation#1130

Merged
caronc merged 12 commits intocaronc:masterfrom
deanmalan:slack-files-upload-deprecation
May 28, 2024
Merged

Slack files upload deprecation#1130
caronc merged 12 commits intocaronc:masterfrom
deanmalan:slack-files-upload-deprecation

Conversation

@deanmalan
Copy link
Contributor

@deanmalan deanmalan commented May 24, 2024

Description:

Related issue (if applicable): #1126

The Slack files.upload method is deprecated. Instead, you now need to use the files.getUploadURLExternal and files.completeUploadExternal methods to upload files to Slack.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage.

Local test result:

Screenshot 2024-05-24 at 11 39 24

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/delenamalan/apprise.git@slack-files-upload-deprecation

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  --attach /path/to/image.png \
  "slack://xoxb-your-slack-key/#your-channel"

@deanmalan deanmalan marked this pull request as ready for review May 24, 2024 12:07
@caronc
Copy link
Owner

caronc commented May 28, 2024

Amazing work! Thank you for this PR!

@caronc caronc merged commit da14b3a into caronc:master May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants