Do not sanitize http:// attachment URLs#1122
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 99.28% 99.29% +0.01%
==========================================
Files 139 139
Lines 18067 18066 -1
Branches 3690 3689 -1
==========================================
+ Hits 17937 17938 +1
+ Misses 121 119 -2
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
Thanks this indeed fixes #1118 for me |
a44eb8f to
10898cc
Compare
Owner
Author
|
I'll need to revisit this in another release Apprise. I can't reproduce the testing on the GitHub servers that hang indefinitely and timeout after these changes. n/m; I found the deadlock situation and resolved it 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #1118
Apprise Attachments that are HTTP based should not sanitize their URLs to the level others are handled at. Hence
http://hostname/?KeYWord=ARGwould parseKeyWordand assign itARG. the subtle difference is in normal circumstances, the key is made lowercase in Apprise to make URL generation easier on the end user.Checklist
flake8)Testing
Anyone can help test this source code as follows: