Custom Plugin Attachment Support Enforced + Added Testing#1115
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
=======================================
Coverage 99.27% 99.28%
=======================================
Files 139 139
Lines 18053 18056 +3
Branches 3688 3689 +1
=======================================
+ Hits 17923 17926 +3
Misses 121 121
Partials 9 9 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #1110
Upon further investigating, the CustomPlugin always has a
utf-8character string; this is confirmed with the added test cases.One thing to note that before this PR, the Custom Plugin module did not support Attachments (as it should have been allowed). This has been fixed in this PR.
Checklist
flake8)Testing
n/a - more unit tests added in this PR