Skip to content

Structlog testing#2

Merged
MigCast9 merged 2 commits intomainfrom
structlog-testing
Apr 17, 2024
Merged

Structlog testing#2
MigCast9 merged 2 commits intomainfrom
structlog-testing

Conversation

@carolinecgilbert
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Added 3 new tests for structlog handler and all tests pass. These tests ensure that that the handler correctly translate and filter attributes of the LogRecord and propagate the trace context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

The tests are for the logging instrumentor that is tested in the tox framework with the following command:

tox -e test-instrumentation-logging
  • Test A

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants