Skip to content

feat: index carbon components - v10#582

Merged
alisonjoseph merged 17 commits into
mainfrom
515-indexing-carbon-components-test
Apr 22, 2022
Merged

feat: index carbon components - v10#582
alisonjoseph merged 17 commits into
mainfrom
515-indexing-carbon-components-test

Conversation

@andreancardona

@andreancardona andreancardona commented Apr 18, 2022

Copy link
Copy Markdown
Contributor

Closes #515

Indexing PR: carbon-design-system/carbon#11265

Testing / reviewing
Run the app locally you should see carbon components listed as a library and the components should render (44 total) with the filters as shown below:

Screen Shot 2022-04-21 at 3 42 49 PM

@andreancardona andreancardona requested review from a team, alisonjoseph and jharvey10 April 18, 2022 17:21
@andreancardona andreancardona marked this pull request as draft April 18, 2022 17:21
Comment thread services/web-app/data/libraries.js Outdated
Comment thread services/web-app/data/libraries.js Outdated
Comment thread services/web-app/data/libraries.js Outdated
andreancardona and others added 3 commits April 19, 2022 17:42
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
@andreancardona andreancardona changed the title feat: testing for carbon components [WIP-TEST] feat: index carbon components Apr 21, 2022
@andreancardona andreancardona marked this pull request as ready for review April 21, 2022 15:10
Comment thread services/web-app/data/libraries.js Outdated
Comment thread services/web-app/data/libraries.js Outdated
@andreancardona andreancardona changed the title [WIP-TEST] feat: index carbon components [WIP-TEST] feat: index carbon components - v10 Apr 21, 2022
@andreancardona andreancardona changed the title [WIP-TEST] feat: index carbon components - v10 feat: index carbon components - v10 Apr 21, 2022

@mattrosno mattrosno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy button

I don't see any links in copy button: http://localhost:3000/assets/carbon-components/latest/copy-button

There should be a demo: https://the-carbon-components.netlify.app/?nav=copy-button

image

Data table

http://localhost:3000/assets/carbon-components/latest/data-table

We sure this should be tagged "input control"?

image

Grid

The grid's demo incorrectly takes you here: https://the-carbon-components.netlify.app/?nav=form

Toolbar

Missing thumbnail.

image

Comment thread services/web-app/data/libraries.js Outdated

@mattrosno mattrosno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need v10 refs.

Comment thread services/web-app/data/libraries.js Outdated
Comment thread services/web-app/data/libraries.js Outdated
@mattrosno

Copy link
Copy Markdown
Contributor

@andreancardona we can merge this if you open a separate issue to fix the copy button, data table, and grid links in the carbon monorepo v10 branch.

@andreancardona

andreancardona commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

@mattrosno I added those v10 refs - I'll take a look at the other items shortly.

Thanks!

PR tracking these fixes here: carbon-design-system/carbon#11269

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alisonjoseph alisonjoseph merged commit 276058b into main Apr 22, 2022
@alisonjoseph alisonjoseph deleted the 515-indexing-carbon-components-test branch April 22, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index Carbon Components

4 participants