fix(pagination): Use pageText instead of itemsPerPageText to fix a11y label#2270
Merged
zvonimirfras merged 3 commits intocarbon-design-system:masterfrom Oct 5, 2022
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Thanks for contributing @exequiel09! Could you please follow these instructions & sign off on the commit: To add your Signed-off-by line to every commit in this branch:
|
… label Signed-off-by: Exequiel Ceasar Navarrete <dev@exequielnavarrete.me>
b3e4647 to
46e8c1c
Compare
Contributor
Author
|
@Akshat55 commit sign-off done |
zvonimirfras
approved these changes
Oct 5, 2022
Contributor
|
🎉 This PR is included in version 4.61.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2264
Update pagination component to fix a11y label of page selector
Changelog
New
N/A
Changed
Change hidden label for page selector
Removed
N/A