Skip to content

fix(DataTable): fixes overflowing sort button and select column spacing#9956

Merged
jnm2377 merged 4 commits into
carbon-design-system:mainfrom
jnm2377:table-checkbox
Oct 29, 2021
Merged

fix(DataTable): fixes overflowing sort button and select column spacing#9956
jnm2377 merged 4 commits into
carbon-design-system:mainfrom
jnm2377:table-checkbox

Conversation

@jnm2377

@jnm2377 jnm2377 commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

Closes #9837

Changelog

  • adds specific width to checkbox column, so that it's not clipped by sortable headers.
  • adds selectable + sortable story under the Selection stories

Testing / Reviewing

  • Review the Select with Sortable story, review that the checkbox is no longer being clipped by the sortable header
  • there should still be 20px of spacing between the checkbox and the sortable header text (4px right padding on checkbox + 16px left padding on sortable btn)

Screen Shot 2021-10-26 at 8 50 55 PM

Screen Shot 2021-10-26 at 8 50 39 PM

@jnm2377 jnm2377 requested a review from laurenmrice October 27, 2021 02:03
@jnm2377 jnm2377 requested a review from a team as a code owner October 27, 2021 02:03
@netlify

netlify Bot commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 10eeca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c21d0d0a89900075e556e

😎 Browse the preview: https://deploy-preview-9956--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 27, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 23e0661

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6178b37dfc9f0400080bfe43

😎 Browse the preview: https://deploy-preview-9956--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 27, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 23e0661

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6178b37ddd01290007c53abc

😎 Browse the preview: https://deploy-preview-9956--carbon-components-react.netlify.app

@netlify

netlify Bot commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 10eeca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c21d07910540008801b20

😎 Browse the preview: https://deploy-preview-9956--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 10eeca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c21d023b0400007ae0277

😎 Browse the preview: https://deploy-preview-9956--carbon-components-react.netlify.app

sstrubberg
sstrubberg approved these changes Oct 27, 2021
View reviewed changes

@sstrubberg sstrubberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done updating the @carbon/styles package too! 🚀

laurenmrice
laurenmrice approved these changes Oct 28, 2021
View reviewed changes

@laurenmrice laurenmrice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jnm2377 jnm2377 enabled auto-merge (squash) October 29, 2021 16:53
@jnm2377 jnm2377 merged commit 6ce1b54 into carbon-design-system:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

+1 more reviewer

@joshblack joshblack joshblack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Batch checkbox in DataTable header is incorrectly sized and is clipped by the next table header when sorted

5 participants

@jnm2377 @tay1orjones @joshblack @sstrubberg @laurenmrice