Skip to content

chore(fileuploaderbutton): remove unused listFiles prop#9915

Merged
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
tay1orjones:9894-remove-unused-prop
Oct 21, 2021
Merged

chore(fileuploaderbutton): remove unused listFiles prop#9915
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
tay1orjones:9894-remove-unused-prop

Conversation

@tay1orjones

@tay1orjones tay1orjones commented Oct 20, 2021

Copy link
Copy Markdown
Member

Closes #9894

Removes an unused listFiles prop that was being spread onto a DOM element, causing errors from React DOM.

Changelog

Removed

  • fileuploaderbutton: remove unused listFiles prop

@tay1orjones tay1orjones requested a review from a team as a code owner October 20, 2021 22:00
@tay1orjones tay1orjones requested a review from a team as a code owner October 20, 2021 22:15
@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 139af08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6171bb6a94f1b6000827ddeb

😎 Browse the preview: https://deploy-preview-9915--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 139af08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6171bb6a22b31300070bd8cc

😎 Browse the preview: https://deploy-preview-9915--carbon-components-react.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 139af08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6171bb6a0abe150008355bfe

😎 Browse the preview: https://deploy-preview-9915--carbon-elements.netlify.app

@kodiakhq kodiakhq Bot merged commit f012e36 into carbon-design-system:main Oct 21, 2021
@kevinsperrine kevinsperrine mentioned this pull request Nov 9, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

+1 more reviewer

@jnm2377 jnm2377 jnm2377 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: FileUploaderButton's listFiles prop is forwarded to DOM element

3 participants

@tay1orjones @sstrubberg @jnm2377