Skip to content

refactor(react): update HeaderNavigation to functional component#9911

Merged
kodiakhq[bot] merged 4 commits into
carbon-design-system:mainfrom
joshblack:refactor/update-header-nav-to-functional
Oct 30, 2021
Merged

refactor(react): update HeaderNavigation to functional component#9911
kodiakhq[bot] merged 4 commits into
carbon-design-system:mainfrom
joshblack:refactor/update-header-nav-to-functional

Conversation

@joshblack

@joshblack joshblack commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Update HeaderNavigation to a functional component.

Changelog

New

  • Add functional component version of HeaderNavigation
  • Add tests for HeaderNavigation

Changed

  • Update entrypoint for UI Shell

Removed

Testing / Reviewing

  • This component did not have tests before, this PR adds in tests so make sure they make sense and pass 😅

@joshblack joshblack requested a review from a team as a code owner October 20, 2021 18:33
@joshblack joshblack requested review from aledavila and dakahn October 20, 2021 18:33
@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 071fc75

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c90467e0601000892f097

😎 Browse the preview: https://deploy-preview-9911--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 071fc75

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c90464992c90007790399

😎 Browse the preview: https://deploy-preview-9911--carbon-components-react.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 071fc75

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c90464992c9000779039b

😎 Browse the preview: https://deploy-preview-9911--carbon-elements.netlify.app

@joshblack

joshblack commented Oct 28, 2021

Copy link
Copy Markdown
Contributor Author

bump @aledavila @dakahn

aledavila
aledavila approved these changes Oct 28, 2021
View reviewed changes

@aledavila aledavila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm works as expected

@kodiakhq kodiakhq Bot merged commit 96f45ee into carbon-design-system:main Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@aledavila aledavila aledavila approved these changes

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @aledavila @dakahn