Skip to content

refactor(react): update SideNavMenu to functional component#9910

Merged
kodiakhq[bot] merged 4 commits into
carbon-design-system:mainfrom
joshblack:refactor/side-nav-menu
Oct 26, 2021
Merged

refactor(react): update SideNavMenu to functional component#9910
kodiakhq[bot] merged 4 commits into
carbon-design-system:mainfrom
joshblack:refactor/side-nav-menu

Conversation

@joshblack

@joshblack joshblack commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Refactors the SideNavMenu component from a class to a functional component. This PR also adds in a scaffold for a v11 migration doc and updates the entrypoint for UIShell to toggle between implementations.

Changelog

New

  • Add functional component for SideNavMenu under UIShell/next/SideNavMenu

Changed

  • Update entrypoint for UIShell to toggle between classic and next versions of SideNavMenu

Removed

Testing / Reviewing

  • Verify tests pass as expected under UIShell/next

@joshblack joshblack requested a review from a team as a code owner October 20, 2021 16:25
@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 32efb50

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61782b209675b80008df4f6a

😎 Browse the preview: https://deploy-preview-9910--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 32efb50

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61782b2084cfaf00079e2f45

😎 Browse the preview: https://deploy-preview-9910--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 32efb50

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61782b20a560610007da44b5

😎 Browse the preview: https://deploy-preview-9910--carbon-components-react.netlify.app

jnm2377
jnm2377 approved these changes Oct 21, 2021
View reviewed changes

@jnm2377 jnm2377 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests are passing and storybook example looks good. 👍🏽

@kodiakhq kodiakhq Bot merged commit be4fa07 into carbon-design-system:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

+1 more reviewer

@jnm2377 jnm2377 jnm2377 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @tay1orjones @jnm2377