fix(button): hcm for ghost icon color contrast#9904
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: e7f7fd6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617044723289a1000719d370 😎 Browse the preview: https://deploy-preview-9904--carbon-react-next.netlify.app |
b47e35d to
6642dda
Compare
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 932d9b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/616f3324ddc46400086996b6 😎 Browse the preview: https://deploy-preview-9904--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 932d9b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/616f3324ed67aa00086420d1 😎 Browse the preview: https://deploy-preview-9904--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: e7f7fd6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617044720e93100007843638 😎 Browse the preview: https://deploy-preview-9904--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: e7f7fd6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61704472026d9a0007d791aa 😎 Browse the preview: https://deploy-preview-9904--carbon-elements.netlify.app |
abbeyhrt
left a comment
There was a problem hiding this comment.
Looks great to me! Thank you for the contribution! 🎉
There was a problem hiding this comment.
Thanks for submitting this fix! A couple things in addition to the change requested in this review below:
- The HCM styles need to be at the very end of the file to ensure they're not overridden
- This fix needs to be mirrored in
packages/carbon-reactpackages/styles
tay1orjones
left a comment
There was a problem hiding this comment.
@kinueng I hope you don't mind - I went ahead and pushed an update to this PR with the suggestions above. Let me know what you think
|
@tay1orjones Thank you helping me spruce up my pull request. I don't mind you adding a commit and I get to learn from your changes. I went with the least riskiest change to the stylesheet since I'm so unfamiliar with the Carbon stylesheet codebase. Retested this PR on my Windows machine using high contrast mode |
|
Fantastic! thanks @kinueng |
Closes #9903
Add CSS specifically for Windows high contrast mode for the ghost style
<Button>Changelog
Changed
Added CSS specific to the ghost styling for the Button that will apply
fill: whiteto the SVG.Testing / Reviewing
Before fix
After fix