Skip to content

fix(button): remove tooltip on click on button icon and tooltip icon#9882

Merged
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
aledavila:tooltip-9521
Oct 21, 2021
Merged

fix(button): remove tooltip on click on button icon and tooltip icon#9882
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
aledavila:tooltip-9521

Conversation

@aledavila

@aledavila aledavila commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Closes #9521

Removes tooltip from showing up after clicking the icon only button and the tooltip.

Changelog

Changed

  • addded tooltipvisibility false on icon only button and dtooltip

Testing / Reviewing

Make sure they are working as intended. Make sure this is the intended fix for removing. Make sure it fits a11y rules.

Should visual focus on tooltip be removed on click?

@aledavila aledavila requested a review from a team as a code owner October 18, 2021 06:11
@netlify

netlify Bot commented Oct 18, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4adbe93

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6171a442d51a3400081179e5

😎 Browse the preview: https://deploy-preview-9882--carbon-react-next.netlify.app

@aledavila aledavila requested review from dakahn and joshblack and removed request for jnm2377 and sstrubberg October 18, 2021 06:11
@netlify

netlify Bot commented Oct 18, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4adbe93

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6171a4418630190007febada

😎 Browse the preview: https://deploy-preview-9882--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 18, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4adbe93

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6171a4410299470008dca264

😎 Browse the preview: https://deploy-preview-9882--carbon-components-react.netlify.app

@aledavila aledavila changed the title fix(button): remove tooltip on click on button in and tooltip icon fix(button): remove tooltip on click on button icon and tooltip icon Oct 18, 2021
@kodiakhq kodiakhq Bot merged commit 4a95fb7 into carbon-design-system:main Oct 21, 2021
@joshblack joshblack mentioned this pull request Dec 1, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@joshblack joshblack joshblack approved these changes

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Switcher] Tool tip sticks and does not go away after opening/closing

3 participants

@aledavila @joshblack @dakahn