Skip to content

feat(modal): deprecate iconDescription#9828

Merged
sstrubberg merged 12 commits into
carbon-design-system:mainfrom
sstrubberg:feat/modal-iconDescription
Oct 21, 2021
Merged

feat(modal): deprecate iconDescription#9828
sstrubberg merged 12 commits into
carbon-design-system:mainfrom
sstrubberg:feat/modal-iconDescription

Conversation

@sstrubberg

@sstrubberg sstrubberg commented Oct 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

REF #9624

Added deprecation warnings for iconDescription for v11.

Changelog

  • Removed iconDescription from Storybook
  • title and aria-label attributes now use the ariaLabel prop instead of iconDescription.
  • The close button now gets an aria-hidden="true"
  • Removed tests involving iconDescription. Added a new test to ensure the aria-hidden is applied to the Close20 icon.

Testing / Reviewing

Review Modal in Storybook and ensure tests are firing off correctly.

Questions

  • Should the aria-label be required now? REF 9466 - thx @abbeyhrt

@netlify

netlify Bot commented Oct 8, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 67be21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61718f885cc8470007c4e0bc

😎 Browse the preview: https://deploy-preview-9828--carbon-react-next.netlify.app

@sstrubberg sstrubberg changed the title feat(modal): deprecate iconDescription new tests feat(modal): deprecate iconDescription Oct 8, 2021
@netlify

netlify Bot commented Oct 8, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 67be21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61718f88512e5300086f0f2b

😎 Browse the preview: https://deploy-preview-9828--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 8, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 67be21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61718f8851d3b200082a8712

😎 Browse the preview: https://deploy-preview-9828--carbon-components-react.netlify.app

@sstrubberg sstrubberg marked this pull request as ready for review October 12, 2021 14:52
@sstrubberg sstrubberg requested review from a team as code owners October 12, 2021 14:52
dakahn
dakahn suggested changes Oct 14, 2021
View reviewed changes
Comment thread packages/react/src/components/Modal/Modal-test.js Outdated
Comment thread packages/react/src/components/Modal/Modal-test.js
@sstrubberg sstrubberg requested a review from dakahn October 18, 2021 17:22
@dakahn

dakahn commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Looks like its getting flagged in Accessibility Checker for not having a label on the close button. adding aria-label="close" should fix this 👍🏾

@dakahn

dakahn commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

glorious work
image

dakahn
dakahn approved these changes Oct 20, 2021
View reviewed changes

@dakahn dakahn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🏄🏾

aledavila
aledavila approved these changes Oct 21, 2021
View reviewed changes

@aledavila aledavila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just looks like you need to update snapshots

@sstrubberg sstrubberg merged commit a9c13ff into carbon-design-system:main Oct 21, 2021
@sstrubberg sstrubberg deleted the feat/modal-iconDescription branch October 21, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@aledavila aledavila aledavila approved these changes

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sstrubberg @dakahn @aledavila