fix(grid): make subgrid work with grid offset#9803
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: f0798d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/616725b697e0590007f1c455 😎 Browse the preview: https://deploy-preview-9803--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: f0798d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/616725b69572990007f25180 😎 Browse the preview: https://deploy-preview-9803--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: f0798d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/616725b55a3c7000096febbf 😎 Browse the preview: https://deploy-preview-9803--carbon-elements.netlify.app |
tay1orjones
left a comment
There was a problem hiding this comment.
I have one question on my review below, but both your example story and the existing offset story look great.
proper.offset.column.reflow.mov
I pushed one small update to this - I noticed the existing stories' styles weren't being applied due to the prefix change.
Ref #9723 (comment)
Ensures that subgrid is supported corectly when the parent grid uses offset.
Changelog
Removed
col-end-nrules since the existingcol-span-nandcol-start-nclasses together are already achieving the expected stylingTesting / Reviewing
Add the test case from the discussion as a story and verify the appearance / behaviour: