Skip to content

feat(tag): add outline variant#9792

Merged
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
janhassel:tag-outline-variant
Oct 4, 2021
Merged

feat(tag): add outline variant#9792
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
janhassel:tag-outline-variant

Conversation

@janhassel

@janhassel janhassel commented Oct 4, 2021

Copy link
Copy Markdown
Member

Closes #9670

Added an outline variant for the Tag component.
Background: $background
Outline: $background-inverse
Text: $text-primary
Hover: $layer-hover

Changelog

New

  • Added outline variant to tag
  • Added cool-gray, warm-gray, high-contrast and outline demos to @carbon/react storybook

Changed

  • Updated API snapshot

Testing / Reviewing

Verify visual appearance is as expected

@janhassel janhassel requested review from a team as code owners October 4, 2021 07:47
@netlify

netlify Bot commented Oct 4, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8b9d823

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615ab2f7a789f000084a54d4

😎 Browse the preview: https://deploy-preview-9792--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 4, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: dccf795

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615ab1a955fc1100079885df

😎 Browse the preview: https://deploy-preview-9792--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 4, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: dccf795

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615ab1a985a9fd0008320400

😎 Browse the preview: https://deploy-preview-9792--carbon-components-react.netlify.app

@netlify

netlify Bot commented Oct 4, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8b9d823

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615ab2f733a2d3000716cc90

😎 Browse the preview: https://deploy-preview-9792--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 4, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8b9d823

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615ab2f785a9fd00083225b5

😎 Browse the preview: https://deploy-preview-9792--carbon-components-react.netlify.app

sstrubberg
sstrubberg approved these changes Oct 4, 2021
View reviewed changes

@sstrubberg sstrubberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kodiakhq kodiakhq Bot merged commit d02a8e5 into carbon-design-system:main Oct 4, 2021
@janhassel janhassel deleted the tag-outline-variant branch October 4, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add a new tag option

3 participants

@janhassel @tay1orjones @sstrubberg