fix(accordion): update arrow spacing for start variant#9777
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 6ea0730 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615b311399c077000805d1c1 😎 Browse the preview: https://deploy-preview-9777--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6ea0730 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615b3113e08f400008528b5a 😎 Browse the preview: https://deploy-preview-9777--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6ea0730 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615b3113b843c00007419056 😎 Browse the preview: https://deploy-preview-9777--carbon-components-react.netlify.app |
tay1orjones
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding it to the styles package as well!
jnm2377
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the fix!
|
@aagonzales could you verify this is all up to spec? It's a visual bug fix for start chevron accordions. |
aagonzales
left a comment
There was a problem hiding this comment.
Yeah it looks correct, if the padding area includes the 16px icon then it would be 32px/spacing-07 there instead.
Currently, the chevrons in the "start"-variant of the Accordion (with the chevrons on the left) have 8px of left spacing whereas the chevrons in the "end"-variant (with the chevrons on the right) have a right spacing of 16px.
After checking with @aagonzales, the left spacing on the "start"-variant should also be 16px / spacing-05.
Before
After
Changelog
Changed
$spacing-05/16px.$spacing-05/16px spacing to the right of the accordion title based on spec from @aagonzales:Testing / Reviewing