Skip to content

fix(notification): actionable non-inline content close button layout bug#9773

Merged
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
tay1orjones:actionable-notification-close-layout-bug
Oct 4, 2021
Merged

fix(notification): actionable non-inline content close button layout bug#9773
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
tay1orjones:actionable-notification-close-layout-bug

Conversation

@tay1orjones

@tay1orjones tay1orjones commented Sep 29, 2021

Copy link
Copy Markdown
Member

Fixes ActionableNotification - content text was running into the close button due to an improperly scoped style.

Changelog

Changed

  • ActionableNotification: text content wraps to respect close button layout

Testing / Reviewing

  • View the ActionableNotification story in the carbon-next storybook.
  • Put some text into the children prop control
  • Validate text doesn't wrap into the close button
  • Make inline prop true, and do the same test to ensure no regressions for inline variant.
Screenshots
bug 🐞 fixed ✅
Screen Shot 2021-09-29 at 3 07 01 PM Screen Shot 2021-09-29 at 3 20 37 PM

@tay1orjones tay1orjones requested a review from a team as a code owner September 29, 2021 20:28
@netlify

netlify Bot commented Sep 29, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d6c3ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615b79fc81b2e0000732b4f1

😎 Browse the preview: https://deploy-preview-9773--carbon-react-next.netlify.app

@netlify

netlify Bot commented Sep 29, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d6c3ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615b79fc81b2e0000732b4ef

😎 Browse the preview: https://deploy-preview-9773--carbon-elements.netlify.app

@netlify

netlify Bot commented Sep 29, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d6c3ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615b79fb71eb6f0007b852a0

😎 Browse the preview: https://deploy-preview-9773--carbon-components-react.netlify.app

@kodiakhq kodiakhq Bot merged commit cd6fc39 into carbon-design-system:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

+1 more reviewer

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tay1orjones @sstrubberg @dakahn