fix(Modal): updates content spacing#9700
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 91708ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615b2a4dd94fea00075dbcae 😎 Browse the preview: https://deploy-preview-9700--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 91708ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615b2a4d57cdb400088df94c 😎 Browse the preview: https://deploy-preview-9700--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 91708ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615b2a4e70623b000879e74d 😎 Browse the preview: https://deploy-preview-9700--carbon-elements.netlify.app |
|
@jnm2377 how does this work for different types of content in the modal? If I remember right, @tw15egan brought this up over in: #8373 (comment) and I was curious what your take on that was |
|
@joshblack I added padding that was specific to One thing I did consider, is that rn the modal content is essentially something like this: so paragraphs technically have 16px + 20% right padding. I considered doing |
Closes #8373
This PR essentially updates the spacing within modals so that any content that is not text spans full width (with 16px padding), and text gets 20% right padding.
(FYI: I previously had a different PR up for this, which I closed).
SPECS:
xs
sm
md, lg, xl
Changelog
hasFormpwithin modal contentTesting / Reviewing