feat(props): update table expand header props#9659
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: e2600de 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615d43ab1036000007a58ad4 😎 Browse the preview: https://deploy-preview-9659--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 18f72e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6140d819827c7e0008bcafcd 😎 Browse the preview: https://deploy-preview-9659--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 18f72e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6140d81af2bbae0007a995c1 😎 Browse the preview: https://deploy-preview-9659--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: e2600de 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615d43ab8fde2f00070e9b6d 😎 Browse the preview: https://deploy-preview-9659--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: e2600de 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615d43ab93fcfb00077caf3b 😎 Browse the preview: https://deploy-preview-9659--carbon-components-react.netlify.app |
…to prop-changes-expando
…into prop-changes-expando
| // enableExpando:PropTypes.bool, | ||
| enableExpando: deprecate( | ||
| PropTypes.bool, | ||
| 'The `renableExpando` prop has been deprecated in favor of `enableToggle`. This prop will be removed in the next major release.' |
There was a problem hiding this comment.
| 'The `renableExpando` prop has been deprecated in favor of `enableToggle`. This prop will be removed in the next major release.' | |
| 'The `enableExpando` prop has been deprecated in favor of `enableToggle`. This prop will be removed in the next major release.' |
There was a problem hiding this comment.
good catch thanks
abbeyhrt
left a comment
There was a problem hiding this comment.
Looks good to me other than a very small typo 🎉
Changelog
This updates table expand header. There are still questions if accordion item: if we truly need the renderExpand prop and what its purpose is.
Changed
enableExpando>enableToggle