fix(Select): fix background issues with inline variant optgroups#9636
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: cd21602 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615b174bd48b250007c4d25d 😎 Browse the preview: https://deploy-preview-9636--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: cd21602 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615b174bccef6900079614cc 😎 Browse the preview: https://deploy-preview-9636--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: cd21602 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615b174b1460730007ab52a1 😎 Browse the preview: https://deploy-preview-9636--carbon-elements.netlify.app |
|
It looks like a lot of this is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1394491 Basically, the For testing:
|
tay1orjones
left a comment
There was a problem hiding this comment.
I'm aware the optgroup does not match the option, but it is at least readable now.
I get what you're saying after looking at inline:
It all looks good for me on Mac - I don't have a windows environment set up yet. @dakahn would you be able to test firefox on windows?
Closes #9625
Closes #9112
Add in a bit more specificity to override default Firefox styles on
optgroupas well as sets the correct background-colorChangelog
Changed
background: $background-hover;as per the issue. Needed to addoptgroupspecificity to correct it in Firefox as wellTesting / Reviewing
I have not been able to test in Windows, but this fixes the Firefox issue. I'm aware the
optgroupdoes not match theoption, but it is at least readable now. The background is set via theselectbackground color (known Firefox bug)For testing:
Need to check each theme in these three scenarios, in Windows and Mac (Firefox)
SelectSelectSelect)