Skip to content

fix(tooltip): Fix tooltip alignment aligned on right hand side of container#9606

Merged
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
TuxedoFish:right-align-issue
Oct 6, 2021
Merged

fix(tooltip): Fix tooltip alignment aligned on right hand side of container#9606
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
TuxedoFish:right-align-issue

Conversation

@TuxedoFish

@TuxedoFish TuxedoFish commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

Closes #9561

  • When tooltip is aligned up against RHS the tooltip appears out of position

Changelog

New

  • N/A

Changed

  • Add a callback to setState(floatingPosition:...) inside _updateMenuSize
  • Will refire _updateMenuSize if the new bounding rectangle is different
  • This can only be fired once

Removed

  • N/A

Testing / Reviewing

  • Align the tooltip up against the RHS and see that the tooltip is correctly positioned

@TuxedoFish TuxedoFish requested a review from a team as a code owner September 5, 2021 20:41
@netlify

netlify Bot commented Sep 5, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d607f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615d49442f24d000088b7ba5

😎 Browse the preview: https://deploy-preview-9606--carbon-react-next.netlify.app

@TuxedoFish TuxedoFish mentioned this pull request Sep 5, 2021
Merged
@netlify

netlify Bot commented Sep 5, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7a478c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61352b97cd9a9d0007925802

😎 Browse the preview: https://deploy-preview-9606--carbon-elements.netlify.app

@netlify

netlify Bot commented Sep 5, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7a478c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61352b97ed0ae200082a238c

😎 Browse the preview: https://deploy-preview-9606--carbon-components-react.netlify.app

@netlify

netlify Bot commented Sep 5, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d607f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615d4944678bbe0007a0218a

😎 Browse the preview: https://deploy-preview-9606--carbon-components-react.netlify.app

@netlify

netlify Bot commented Sep 5, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d607f3a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615d49443026680008028cfa

😎 Browse the preview: https://deploy-preview-9606--carbon-elements.netlify.app

jnm2377
jnm2377 approved these changes Sep 15, 2021
View reviewed changes

@jnm2377 jnm2377 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. I compared to live tooltip story, and fix is working. 👍🏽 Thanks for the contribution! 💯

@kodiakhq kodiakhq Bot merged commit 3af8a94 into carbon-design-system:main Oct 6, 2021
@emyarod emyarod mentioned this pull request Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

+1 more reviewer

@jnm2377 jnm2377 jnm2377 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip issue when aligned to right of screen

3 participants

@TuxedoFish @tay1orjones @jnm2377